Migrate documentation: Remove docs from etcd-io/etcd #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried a first pass at removing the documentation as per issue etcd-io/website#97. Could you look at this PR to ensure that I've not broken any of the documentation generation tools, and that the release scripts still work as intended? |
|
I think that you can move. If we discover broken scripts, we will fix them when we will attempt the release. |
|
Thanks @ptabor, in that case, I'll mark this PR "ready for review" |
spzala
reviewed
Feb 2, 2021
|
I'm for merging. |
Closed
|
@nate-double-u please resolve conflicts when you get a chance :) |
|
@nate-double-u the commit 2 doesn't sound right that I think you have created to fix the merge conflict. You just need to rebase not overwrite. Thanks! |
nate-double-u
force-pushed
the
97-remove-docs-from-etcd
branch
from
b73441d to
2511790
Compare
Leaving docs, files, etc that are required for generated documentation fixes etcd-io/website#97 Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
nate-double-u
force-pushed
the
97-remove-docs-from-etcd
branch
from
2511790 to
2afa5ff
Compare
|
@spzala it's rebased now, thx :) |
|
@nate-double-u cool,thanks :) |
|
Thanks everyone! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing Documentation from etcd-io/etcd as a part of migrating it to the website.
fixes etcd-io/website#97
Do not merge before related PR: etcd-io/website#99
Affected PRs (these may have to be redirected towards etcd-io/website):